From 5b493f665332142c36053a5108e51b65f8099410 Mon Sep 17 00:00:00 2001 From: cat_in_136 Date: Mon, 4 Mar 2019 23:01:59 +0900 Subject: [PATCH 1/2] fix bug where Like buttons are placed at wrong position on notes in issues cat-in-136/redmine_hearts#23 --- assets/javascripts/transplant_heart_link_with_counter.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/assets/javascripts/transplant_heart_link_with_counter.js b/assets/javascripts/transplant_heart_link_with_counter.js index 1dfe9ae..36fe6d9 100644 --- a/assets/javascripts/transplant_heart_link_with_counter.js +++ b/assets/javascripts/transplant_heart_link_with_counter.js @@ -17,8 +17,10 @@ $(function() { let heartable_subject = getHeartableSubject(link); let num_insert = 0; + console.debug({heartable_subject, link}); + if (num_insert === 0) { - let note_subject = heartable_subject.replace(/^[-a-z0-9]+-/, "note-"); + let note_subject = heartable_subject.replace(/^[-a-z0-9]+-/, "change-"); num_insert += $(link).prependTo($("#" + note_subject + " .journal-actions")).length; } if (num_insert === 0) { From 316c01da9c306111ac7946156407450e0743c539 Mon Sep 17 00:00:00 2001 From: cat_in_136 Date: Mon, 4 Mar 2019 23:15:43 +0900 Subject: [PATCH 2/2] update .travis.yml --- .travis.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 64da902..3efc350 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,16 +5,16 @@ cache: - redmine/vendor/bundle matrix: include: + - rvm: 2.6.1 + env: REDMINE_VERSION=4.0.2 - rvm: 2.5.3 - env: REDMINE_VERSION=4.0.0 -# - rvm: 2.6.0-rc2 -# env: REDMINE_VERSION=3.4.7 + env: REDMINE_VERSION=4.0.2 - rvm: 2.5.3 - env: REDMINE_VERSION=3.4.7 + env: REDMINE_VERSION=3.4.9 - rvm: 2.4.5 - env: REDMINE_VERSION=3.4.7 + env: REDMINE_VERSION=3.4.9 - rvm: 2.3.8 - env: REDMINE_VERSION=3.4.7 + env: REDMINE_VERSION=3.4.9 before_install: bash -x bin/travisci_before_install.sh before_script: bash -x bin/travisci_before_script.sh script: bash -x bin/travisci_exec_test.sh