Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown identifiers in Test_Generator_SE* examples #17

Open
maltelenz opened this issue Nov 5, 2020 · 2 comments
Open

Unknown identifiers in Test_Generator_SE* examples #17

maltelenz opened this issue Nov 5, 2020 · 2 comments

Comments

@maltelenz
Copy link
Contributor

The examples in ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE* (and classes they depend on) reference identifiers that do not exist.

These are diagnostic outputs from System Modeler:

[3] 16.46 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE [22:11-22:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE [30:13-30:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE [29:13-29:13] Unknown identifier powerConnection.f.
[4] 16.48 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker [24:11-24:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_Breaker [31:13-31:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_Breaker [30:13-30:13] Unknown identifier powerConnection.f.
Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_breaker completed with 3 errors.
[5] 16.48 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com 
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com [22:11-22:11] Unknown identifier grid.connection.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_com [26:13-26:13] Unknown identifier powerConnection.W.
Error: ThermoPower.PowerPlants.ElectricGeneratorGroup.Components.OldElementsSwingEquation.Generator_SE_com [25:13-25:13] Unknown identifier powerConnection.f.
Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE_com completed with 3 errors.
@casella
Copy link
Owner

casella commented Nov 5, 2020

The PowerPlants package is in an awkward state. It was devloped many years ago by a former student of mine, then we changed the structure of the Flow1D models, that are used for all heat exchangers, and kept the old Flow1D models as deprecated for backwards compatibility. The idea was to upgrade PowerPlants to the new Flow1D models, this work was started on a branch but I never had time to complete it.

I guess the best idea is to remove PowerPlants from the library and eventually release it separately when the refactoring is complete, I'll try to do that ASAP. For the time being, better not to waste your time on that sub-library

@maltelenz
Copy link
Contributor Author

For the time being, better not to waste your time on that sub-library

Thank you for that useful information! I'll ignore it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants