Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate deployed pods with version of component #223

Closed
vijaykatam opened this issue Jun 11, 2021 · 7 comments
Closed

Annotate deployed pods with version of component #223

vijaykatam opened this issue Jun 11, 2021 · 7 comments
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor

Comments

@vijaykatam
Copy link
Contributor

Describe the problem/challenge you have
When deploying packages with imgpkg bundles the tag of a container is replaced with sha256 in a deployed pod/deployement/daemonset. This is a challenge for serviceability when I need to figure out what tag of a container is deployed. It requires me look at the sha and comparing in registry and if I don't have access to registry then I have to expand the imgpkg bunde retrived from Package CR and look in .images.yml

Describe the solution you'd like
Add a kapp annotation with the tag of the container on the Pod/Deployment/Daemonset objects.

Anything else you would like to add:
It would be useful to have something like imgpkg inspect instead of me trying to do something like imgpkg pull -b bundle -o /tmp/bundle && cat /tmp/bundle.imgpkg/images.yml to inspect tags of containers.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@vijaykatam vijaykatam added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jun 11, 2021
@timothysc
Copy link

👍 from me.

@cppforlife
Copy link
Contributor

cppforlife commented Jun 11, 2021

kbld in theory already has this capability (it generates kbld.k14s.io/images annotation); however, we are not recording "source" tag information when generating .imgpkg/images.yml. so to address this we need:

  • record metadata at the time of .imgpkg/images.yml generation (we got annotations field for each image)
  • use this metadata when we apply updated image refs and annotate resources

im 👍 for this feature as well.

cc @aaronshurley @vibhas

@jorgemoralespou
Copy link

jorgemoralespou commented Jun 11, 2021

I think this has already been requested: carvel-dev/imgpkg#124, although from the end user point of view, it would probably need to have some UX in the package CLI

@vijaykatam
Copy link
Contributor Author

We can ignore imgpkg inspect part in lieu of carvel-dev/imgpkg#124. The other part of the request is still valid.

@frapposelli
Copy link

👍🏻 from me for this feature.

@aaronshurley aaronshurley added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jun 22, 2021
@aaronshurley
Copy link
Contributor

We created an issue for kbld and have prioritized it. Once that is completed and a release is published, kapp-controller will just need to update its kbld.

@danielhelfand danielhelfand added the good first issue An issue that will be a good candidate for a new contributor label Jul 30, 2021
@danielhelfand
Copy link
Contributor

This has been addressed in v0.25.0: https://github.com/vmware-tanzu/carvel-kapp-controller/releases/tag/v0.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor
Projects
None yet
Development

No branches or pull requests

7 participants