Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl package repository release Should Allow Control of Image Tags #1639

Closed
nebhale opened this issue Nov 13, 2024 · 9 comments · Fixed by #1664
Closed

kctrl package repository release Should Allow Control of Image Tags #1639

nebhale opened this issue Nov 13, 2024 · 9 comments · Fixed by #1664
Assignees
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed carvel-triage This issue has not yet been reviewed for validity cli Issue for kapp-controller cli enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@nebhale
Copy link

nebhale commented Nov 13, 2024

Describe the problem/challenge you have
Currently, there is no way to control the image tags for created and published package repository imgpkg bundles. This prevents the creation of a package repository with a version that includes any build metadata, e.g. 0.0.1+git.c9cc39a

Describe the solution you'd like
The kctrl package repository release command should gain a --tag flag that is the equivalent of the kctrl package release command's --tag flag.

Anything else you would like to add:
Slack


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@nebhale nebhale added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Nov 13, 2024
@praveenrewar praveenrewar added carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli and removed carvel-triage This issue has not yet been reviewed for validity labels Nov 15, 2024
@mamachanko
Copy link
Contributor

@nebhale @praveenrewar This might be a duplicate of #1409

@nebhale
Copy link
Author

nebhale commented Nov 18, 2024

They are related in the sense that they're both triggered by the same thing (the inability to use build metadata) but in detail they're different. My specific ask is for a flag to create parity between kctrl package release and kctrl package repository release and the other requests an automated mapping.

@renuy renuy moved this to Prioritized Backlog in Carvel Dec 6, 2024
@renuy renuy added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Dec 6, 2024
@renuy renuy moved this from Prioritized Backlog to In Progress in Carvel Dec 19, 2024
@devanshuVmware
Copy link
Contributor

@nebhale Currently, the version provided by the user in the args is the added as image tag (or the unix timestamp if version is empty)
If I understand correctly, with this change, the user will be able to override that version tag by providing a user specific tag.
The image tag applied would take precedence in following order:

  1. --tag
  2. --version
  3. unix time stamp

@nebhale
Copy link
Author

nebhale commented Dec 19, 2024

@devanshuVmware Do you have to hand, the precedence for how the kctrl package publish works? I thought that --version wasn't included in that precedence hierarchy.

@devanshuVmware
Copy link
Contributor

@nebhale Currently, the tag that is applied to the imgpkg bundle image is:
if --version flag is provided, apply it
else, add the unix timestamp as tag

with the introduction of --tag flag, I understand, its value should take precedence as tag, even if the user provides a value for the --version flag
if the --tag is not provided but --version is , then --version value will be used as tag,
if neither are provided, the default tag would be unix timestamp

@nebhale
Copy link
Author

nebhale commented Dec 20, 2024

Yeah, I have no strong opinion other than consistency with the package behavior 😀. Looks like that's the path you're heading down.

@github-project-automation github-project-automation bot moved this from In Progress to Closed in Carvel Dec 25, 2024
@nebhale
Copy link
Author

nebhale commented Dec 30, 2024

Validated this works as expected. Is there a regular release cadence for the project that I should expect this to fall into?

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Dec 30, 2024
@devanshuVmware
Copy link
Contributor

Validated this works as expected. Is there a regular release cadence for the project that I should expect this to fall into?

Thanks for validating it @nebhale !
The next release for KC is planned towards end of Jan. However, we can make an early release if you need it sooner.

@nebhale
Copy link
Author

nebhale commented Jan 2, 2025

It’d be helpful to have it released earlier (we’d start using the new feature the first day it’s available) but at the same time, this isn’t make-or-break for us, so don’t kill yourself trying to get it out the door.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed carvel-triage This issue has not yet been reviewed for validity cli Issue for kapp-controller cli enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants