-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kctrl package repository release
Should Allow Control of Image Tags
#1639
Comments
@nebhale @praveenrewar This might be a duplicate of #1409 |
They are related in the sense that they're both triggered by the same thing (the inability to use build metadata) but in detail they're different. My specific ask is for a flag to create parity between |
@nebhale Currently, the version provided by the user in the args is the added as image tag (or the unix timestamp if version is empty)
|
@devanshuVmware Do you have to hand, the precedence for how the |
@nebhale Currently, the tag that is applied to the imgpkg bundle image is: with the introduction of |
Yeah, I have no strong opinion other than consistency with the package behavior 😀. Looks like that's the path you're heading down. |
Validated this works as expected. Is there a regular release cadence for the project that I should expect this to fall into? |
Thanks for validating it @nebhale ! |
It’d be helpful to have it released earlier (we’d start using the new feature the first day it’s available) but at the same time, this isn’t make-or-break for us, so don’t kill yourself trying to get it out the door. |
Describe the problem/challenge you have
Currently, there is no way to control the image tags for created and published package repository imgpkg bundles. This prevents the creation of a package repository with a version that includes any build metadata, e.g.
0.0.1+git.c9cc39a
Describe the solution you'd like
The
kctrl package repository release
command should gain a--tag
flag that is the equivalent of thekctrl package release
command's--tag
flag.Anything else you would like to add:
Slack
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: