Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work the configuration properties to support multiple buckets, credentials and regions #137

Open
3 tasks
carlspring opened this issue Dec 14, 2020 · 0 comments
Labels
help wanted Extra attention is needed on hold

Comments

@carlspring
Copy link
Owner

carlspring commented Dec 14, 2020

Task Description

At the moment, it's not possible to use multiple buckets, credentials and regions. In a more sophisticated application this would be quite a limitation.

The format of the amazon.properties currently looks like this:

s3fs.bucket.name=/bucket
s3fs.access.key=AKIADEMOACCESSKEY
s3fs.secret.key=sfsoj291aSFfasfsafs1fsa1
s3fs.region=eu-west-2
s3fs.protocol=https

Once #136 has been implemented, (and the underscores in the properties have been converted to dots), we should consider doing something like this:

s3fs.${configurationName}.bucket.name=/bucket
s3fs.${configurationName}.access.key=AKIADEMOACCESSKEY
s3fs.${configurationName}.secret.key=sfsoj291aSFfasfsafs1fsa1
s3fs.${configurationName}.region=eu-west-2
s3fs.${configurationName}.protocol=https

For example:

s3fs.filestore1.bucket.name=/bucket
s3fs.filestore1.access.key=AKIADEMOACCESSKEY
s3fs.filestore1.secret.key=sfsoj291aSFfasfsafs1fsa1
s3fs.filestore1.region=eu-west-2
s3fs.filestore1.protocol=https

This is just a proposal, which is open to better suggestions, if anyone has such.

Tasks

The following tasks will need to be carried out:

  • Re-work the properties file for the tests.
  • Implement the necessary changes to the code.
  • Update the documentation.

Task Relationships

This task:

Help

@carlspring carlspring added the help wanted Extra attention is needed label Dec 14, 2020
@carlspring carlspring added this to the 1.0.0 milestone Jan 23, 2021
@carlspring carlspring removed this from the 1.0.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed on hold
Projects
None yet
Development

No branches or pull requests

1 participant