Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating ring and time fields for lidars #416

Open
Opletts opened this issue Nov 24, 2020 · 1 comment
Open

Generating ring and time fields for lidars #416

Opletts opened this issue Nov 24, 2020 · 1 comment

Comments

@Opletts
Copy link

Opletts commented Nov 24, 2020

Velodyne lidars publish PointCloud2 messages with the fields array containing :

  • x , type : float32
  • y , type : float32
  • z , type : float32
  • intensity , type : float32
  • ring , type : uint16
  • time , type : float32

ring : Tells us which channel of the lidar the point belongs to.
time : Tells us the relative time at which the point was received during one rotation. If the rotation_frequency is 10Hz, values would vary between 0-0.1s)

Carla only publishes XYZI points, not XYZIRT. I think adding these two fields would be quite useful. I've made changes locally to generate ring in lidar.py and can open a PR for review.

Generating the time field on the other hand is quite difficult. We've already received the binary data in lidar.py so it's impossible to get that field here. I'm guessing changes to the lidar api in Carla would be required to make this possible. Any suggestions?

@joel-mb
Copy link
Contributor

joel-mb commented Dec 4, 2020

Hi @Opletts!
Please, feel free to open a PR to add the ring field.
Regarding the time field, you are right. Modifications in CARLA would be required. I suggest opening an issue in the CARLA repo or contribute with your changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants