Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate pipeline fails if there's no new commit #4895

Closed
Tracked by #4917
abailly opened this issue Dec 30, 2024 · 2 comments · Fixed by #4936
Closed
Tracked by #4917

Release candidate pipeline fails if there's no new commit #4895

abailly opened this issue Dec 30, 2024 · 2 comments · Fixed by #4936
Labels
Bug CI CI related

Comments

@abailly
Copy link
Collaborator

abailly commented Dec 30, 2024

As demonstrated by this failure and the previous ones from 2024-12-20, the rc pipeline breaks when there's no new commit.
https://buildkite.com/cardano-foundation/cardano-wallet-release/builds/605#01941402-134c-4a3e-829f-f984e5dc3708

This should not be the case obviously. Several possible solutions sprint to my mind:

  • Simply ignore the pipeline if there's no change (bonus point: if the previous rc pipeline is red, try again with retag)
  • Retag the previous build's artifacts (seem complicated?)
  • Relaunch pipeline with same commit but different tag
@abailly abailly added Bug CI CI related labels Dec 30, 2024
@abailly
Copy link
Collaborator Author

abailly commented Dec 30, 2024

So the real problem is that the script reads the date of the latest release from the tags, which in this case was v2024-12-20 but unfortunately this release never happened because of an issue in bump.sh portal which did not display correctly the version tag. I will just remove the tag from the remote and the RC pipeline should proceed normally.

@paolino
Copy link
Collaborator

paolino commented Jan 13, 2025

I think it should fail. We cannot release the same day because of our (no comment) versioning choice. #4936 clear this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CI CI related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants