Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update web-component exports #18312

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Jan 8, 2025

Closes #18311

Similar to this PR, almost all the folder mappings (except es/components/* in the exports field of @carbon/web-components package.json are deprecated. The * is needed for Node 18+ applications.

Changelog

Changed

  • update the folder mappings, removing the specific "./es/components/* and ./es/globals/ subpaths since ./es/* should cover these paths.

Testing / Reviewing

We'll probably have to build this PR locally and do a yarn pack within the web-components folder to generate the package.tgz to test with

@annawen1 annawen1 requested a review from a team as a code owner January 8, 2025 21:15
@annawen1 annawen1 requested review from kennylam and emyarod January 8, 2025 21:15
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9a1e1fa
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/677eeaffc1805e00080a875a
😎 Deploy Preview https://deploy-preview-18312--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9a1e1fa
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/677eeafffda1350008faf305
😎 Deploy Preview https://deploy-preview-18312--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9a1e1fa
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/677eeafff15e5600087425c0
😎 Deploy Preview https://deploy-preview-18312--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (9217609) to head (9a1e1fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18312   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4690     4690           
=======================================
  Hits        12150    12150           
- Misses       2120     2121    +1     
+ Partials      165      164    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 marked this pull request as draft January 9, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icon exports]: error when trying to use the icon exports from @carbon/web-components package
1 participant