Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update who-uses-carbon.mdx #4360

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Update who-uses-carbon.mdx #4360

merged 3 commits into from
Nov 18, 2024

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Nov 14, 2024

The link to carbon for ibm.com was 404ing.
On the page, the link points to https://www.ibm.com/standards/web/carbon-for-ibm-dotcom/?_gl=1*g1kxqm*_ga*MTkzMjY0MTU3NC4xNjkyODI2ODcz*_ga_FYECCCS21D*MTczMTYyMjI4OC40NzMuMS4xNzMxNjIzOTE0LjAuMC4w
although this long string is not appearing in the code. No idea what's going on there, but the link was incorrect even without it, so I have updated the link

Closes #

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

The link to carbon for ibm.com was 404ing (with a very odd string extension not in the code).
I have updated the link
@mbgower mbgower requested review from a team as code owners November 14, 2024 22:44
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 6:42am

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I fixed the formatting to pass CI

Kritvi-bhatia17

This comment was marked as duplicate.

@Kritvi-bhatia17 Kritvi-bhatia17 self-requested a review November 18, 2024 06:40
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kodiakhq kodiakhq bot merged commit 1e86906 into main Nov 18, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the mbgower-patch-1 branch November 18, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants