fix: Updated the Dropdown component's Usage tab to address a11y comments #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kritvi-bhatia17
requested review from
tay1orjones,
ariellalgilmore,
oliviaflory,
mbgower and
laurenmrice
laurenmrice
requested changes
Oct 31, 2024
mbgower
reviewed
Nov 1, 2024
…bon-website into Dropdown_a11y(usage)
laurenmrice
requested changes
Nov 6, 2024
There was a problem hiding this comment.
- The AI images (default/fluid) on the Usage tab seem to still have the top border turned on under the focus state. They should be off.
- In the content section, for the part about the carbon tooltip on ellipses option text, we currently do not show it this way in code; instead, we show a browser-based tooltip. This should be a separate design issue that we need to come to a decision on to have more consistency across our components with how we treat ellipses on text. If a carbon tooltip is the desired design from a11y, we can look into that. Since we don't show this in code right now for dropdowns, I would remove it from these docs for now because we want to show information here that is currently 1:1 with code.
laurenmrice
approved these changes
Nov 7, 2024
|
Hi @mbgower, @tay1orjones, @ariellalgilmore! |
|
Hi @mbgower, could you please review this PR? Thanks! |
Kritvi-bhatia17
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
DO NOT MERGE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3526
This PR updates the Dropdown component Usage tab to incorporate comments from the referenced issue. Additionally, the content on the Usage tab has been aligned with the latest focus state discussion.
Changelog
Changed