Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoD]: PDLC + contribution #4331

Merged
merged 9 commits into from
Oct 29, 2024
Merged

[DoD]: PDLC + contribution #4331

merged 9 commits into from
Oct 29, 2024

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Oct 21, 2024 •
edited
Loading

Closes #4294

Changelog

New

  • New page under Contributing to explain the cross-over between PDLC and the contribution process.

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 5:50pm

@aagonzales aagonzales marked this pull request as ready for review October 23, 2024 14:14
@aagonzales aagonzales requested review from a team as code owners October 23, 2024 14:14
Kritvi-bhatia17
Kritvi-bhatia17 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anna! This looks really good and solid—amazing work! 🔥
I just added a small comment, nothing major, and it can be left out if it’s not needed.

While reviewing this, I was wondering if there’s a page that covers the contribution awards?

src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
laurenmrice
laurenmrice requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, Anna! Just highlighted some grammar related things below:

src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/product-development-lifecycle/index.mdx Outdated Show resolved Hide resolved
Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

laurenmrice
laurenmrice approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!

@kodiakhq kodiakhq bot merged commit beb7aea into carbon-design-system:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@jeanservaas jeanservaas Awaiting requested review from jeanservaas

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DoD] Refine PDLC + contribution process docs
4 participants
@aagonzales @alisonjoseph @laurenmrice @Kritvi-bhatia17