Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags: Remove AI presence for operable and selectable tags #4318

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Tags: Remove AI presence for operable and selectable tags #4318

merged 4 commits into from
Oct 15, 2024

Conversation

aagonzales
Copy link
Member

Related carbon-design-system/carbon#17694

Changelog

Removed

  • Remove operable and dismissable tags from the AI presence images

@aagonzales aagonzales requested review from a team as code owners October 11, 2024 21:00
@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Oct 15, 2024 7:42pm

Kritvi-bhatia17
Kritvi-bhatia17 reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aagonzales!
Everything looks good, but I noticed one small issue. I checked in two different browsers, and while the Usage tab looks fine, the image in the Style tab doesn’t show the updated version. Can you please confirm this? If it's correct, I’ll approve it. Thanks!

image

@aagonzales
Copy link
Member Author

@Kritvi-bhatia17 yeah I'm not sure why the preview isn't loading the new image version...

@Kritvi-bhatia17
Copy link
Contributor

@Kritvi-bhatia17 yeah I'm not sure why the preview isn't loading the new image version...

Hi @guidari, @alisonjoseph! could you please help us with this.

@alisonjoseph
Copy link
Member

It's working locally for me and showing correct images, just fixed the formatting and pushed an update, hopefully the preview deploys.

Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alison, it's working fine now!

LGTM 🚀

@kodiakhq kodiakhq bot merged commit e81314b into carbon-design-system:main Oct 15, 2024
7 checks passed
@aagonzales aagonzales deleted the ai-tag branch October 21, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@guidari guidari guidari approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@thyhmdo thyhmdo Awaiting requested review from thyhmdo thyhmdo is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aagonzales @Kritvi-bhatia17 @alisonjoseph @guidari