Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add carbon svg to mdxicon component #4307

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 1, 2024

Noticed a broken image on new Deprecations page
Screenshot 2024-10-01 at 8 45 12 AM

Added the carbon icon to our MDXIcon component for easier use throughout the website

Changelog

  • add carbon.svg to MDXIcon component
  • update all references to carbon.svg to use MDXIcon component

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem 🛑 Canceled (Inspect) Oct 2, 2024 1:55pm

Copy link
Contributor

@benjamin-kurien benjamin-kurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge

@Kritvi-bhatia17 Kritvi-bhatia17 self-requested a review October 2, 2024 13:37
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that Alison! LGTM 🚀

@alisonjoseph alisonjoseph enabled auto-merge (squash) October 2, 2024 13:39
@alisonjoseph alisonjoseph disabled auto-merge October 2, 2024 13:57
@alisonjoseph alisonjoseph merged commit c230139 into carbon-design-system:main Oct 2, 2024
6 of 7 checks passed
@alisonjoseph alisonjoseph deleted the image-fix branch October 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants