-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: title on AI component cards #4300
fix: title on AI component cards #4300
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aagonzales, could you please confirm whether the font size here should be 12px to match the Components’ Overview cards, or should it be 14px?
@alisonjoseph thanks for fixing this so quickly! Although not directly related to this issue, just wanted to confirm with you—are these ImageCards responsive? 🤔
@Kritvi-bhatia17 @aagonzales ah yea they are different font sizes. The AI page is using the and yes they should be responsive by default |
@Kritvi-bhatia17 @alisonjoseph I think its fine that they are different font sizes since they wont be seen together on the same page. I don't think its worth doing any extra work or customization just for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks @alisonjoseph & @aagonzales for the confirmation!
LGTM 🚀
Closes #4283
Changelog