Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Definition of done #4273

Merged
merged 22 commits into from
Oct 2, 2024

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Sep 20, 2024

Closes #4256

Rearrange and added new pages under the "Contributing" section.

Changelog

New

  • Component checklist page

Changed

  • Moved "Contributing/Code" and "Contributing/Design" under "Contributing/Getting started"

Testing

  • Read content for typos etc
  • Make sure vercel has passed before opening the preview link otherwise it may show old content.

Question

  • For devs: Do you know of any way to better balance on the table columns for the 3rd column is so large compared to the second column?

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 2:53pm

@aagonzales
Copy link
Member Author

@kennylam @ariellalgilmore could you help redeploy Vercel here so we can get a preview link up for review?

@ariellalgilmore
Copy link
Member

deploy preview is up to date and also updated so it would pass the ci/format tests

Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aagonzales, awesome work! 🏅
I have just highlighted a couple of typos (ect changed to etc) and added full stop wherever it was missing.
(Please ignore if irrelevant)

src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
src/pages/contributing/component-checklist/index.mdx Outdated Show resolved Hide resolved
@alina-jacob
Copy link
Member

alina-jacob commented Sep 30, 2024

It would be nice to have all the tables/structured lists aligned (i know its tough with all the bullet points), but because all the content is table after table, it'd be nice to have it all aligned! Might also look neater for those reading it at various breakpoints or a vertical monitor!

image
image

@aagonzales
Copy link
Member Author

aagonzales commented Sep 30, 2024

@alina-jacob Alison actually fixed the table alignment issue last week but the preview link with Vercel doesn't seem to be working/updated.

@alisonjoseph
Copy link
Member

@alina-jacob @aagonzales The deploy preview is working now https://carbondesignsystem-git-fork-aagonza-a0e4bd-carbon-design-system.vercel.app/contributing/component-checklist/

@alina-jacob alina-jacob merged commit 1253405 into carbon-design-system:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DoD] Add with new content and IA changes to website
7 participants