-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Definition of done #4273
Docs: Definition of done #4273
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kennylam @ariellalgilmore could you help redeploy Vercel here so we can get a preview link up for review? |
deploy preview is up to date and also updated so it would pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aagonzales, awesome work! 🏅
I have just highlighted a couple of typos (ect changed to etc) and added full stop wherever it was missing.
(Please ignore if irrelevant)
@alina-jacob Alison actually fixed the table alignment issue last week but the preview link with Vercel doesn't seem to be working/updated. |
Co-authored-by: Alina Jacob <[email protected]>
@alina-jacob @aagonzales The deploy preview is working now https://carbondesignsystem-git-fork-aagonza-a0e4bd-carbon-design-system.vercel.app/contributing/component-checklist/ |
Jeannie's small type updates
Closes #4256
Rearrange and added new pages under the "Contributing" section.
Changelog
New
Component checklist
pageChanged
Testing
Question