Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pagination table #4267

Merged

Conversation

laurenmrice
Copy link
Member

Closes #4265

Fixes some markdown in a table on the Pagination Usage tab

Changelog

Removed

  • Removed some extra columns

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem 🛑 Canceled (Inspect) Sep 23, 2024 6:32pm

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the preview link is still building on my end, even after trying different browsers. I'm not quite sure what's causing the issue. 🤔
Screenshot 2024-09-18 at 9 45 28 PM

@laurenmrice
Copy link
Member Author

@Kritvi-bhatia17 It is working for me. Here is the direct link to it: https://carbondesignsystem-git-fork-laurenm-5d8917-carbon-design-system.vercel.app/components/pagination/usage/

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laurenmrice laurenmrice enabled auto-merge (squash) September 19, 2024 17:56
@laurenmrice
Copy link
Member Author

This PR is ready to merge in but is having a vercel deployment issue.

@alisonjoseph alisonjoseph merged commit 2e453db into carbon-design-system:main Sep 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] Bug with the variants table of Pagination
4 participants