Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tile) feature flag usage, style, code tab update #4266

Merged
merged 41 commits into from
Oct 11, 2024
Merged

docs(tile) feature flag usage, style, code tab update #4266

merged 41 commits into from
Oct 11, 2024

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Sep 18, 2024 •
edited
Loading

Closes #4225

This PR updates the Tile component Usage, Style, and Code tabs to include feature flag information and images. The content on the Usage and Style tabs have also been updated with the new content templates.

Note: Links in various places to the "Feature Flag tab" have not been updated yet, because that page is not live yet.

Changelog

New

Usage:

  • Page tag
  • Content
  • Images

Style:

  • Content
  • Images

Code:

  • Resource card tag
  • Content

Changed

  • Content and images

Removed

  • Images and content that needed to be taken out

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 8:43pm

@laurenmrice laurenmrice marked this pull request as ready for review September 20, 2024 12:30
@laurenmrice laurenmrice requested review from a team as code owners September 20, 2024 12:30
@laurenmrice laurenmrice requested review from Kritvi-bhatia17 and removed request for RichKummer September 23, 2024 13:16
@laurenmrice
Copy link
Member Author

laurenmrice commented Oct 10, 2024 •
edited
Loading

@guidari For some reason there is a change to the Structured list style.mdx file in this PR but it should not be there and is causing a conflict. When you get some time, could you help me remove it from this PR?

@guidari
Copy link
Contributor

guidari commented Oct 10, 2024

Hey @laurenmrice
I guess now is everything fixed!

aagonzales
aagonzales approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job y'all!

sstrubberg
sstrubberg approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kodiakhq kodiakhq bot merged commit e0c518e into carbon-design-system:main Oct 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@Kritvi-bhatia17 Kritvi-bhatia17 Awaiting requested review from Kritvi-bhatia17

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Flags] Tile: add feature flag content to Usage, Style, and Code tabs
7 participants
@laurenmrice @Kritvi-bhatia17 @guidari @aagonzales @sstrubberg @thyhmdo @alisonjoseph