Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(husky): fix pre-commit hook #4260

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore(husky): fix pre-commit hook #4260

merged 2 commits into from
Sep 13, 2024

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Sep 12, 2024 •
edited
Loading

Update husky pre-commit hook to prevent it trying to run commands that don't exist.

Changelog

New

  • add prepare script for Husky

Changed

  • update husky command in pre-commit script

Removed

  • husky entry in package.json

@kennylam kennylam requested a review from annawen1 September 12, 2024 14:58
@kennylam kennylam requested review from a team as code owners September 12, 2024 14:58
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem 🛑 Canceled (Inspect) Sep 12, 2024 3:49pm

tay1orjones
tay1orjones reviewed Sep 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
annawen1
annawen1 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally - was able to commit with no issues!

@kennylam kennylam closed this Sep 13, 2024
@kennylam kennylam reopened this Sep 13, 2024
@kennylam kennylam merged commit 01840c9 into carbon-design-system:main Sep 13, 2024
10 checks passed
@kennylam kennylam deleted the chore/fix-husky-pre-commit-hook branch September 13, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones left review comments

@annawen1 annawen1 annawen1 approved these changes

@aagonzales aagonzales aagonzales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @tay1orjones @aagonzales @annawen1