Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Content Design Guild] Data table component topic is missing content #4235

Closed
lesnider opened this issue Sep 2, 2024 · 4 comments · Fixed by #4194 or #4312
Closed

[UI Content Design Guild] Data table component topic is missing content #4235

lesnider opened this issue Sep 2, 2024 · 4 comments · Fixed by #4194 or #4312

Comments

@lesnider
Copy link
Contributor

lesnider commented Sep 2, 2024

https://carbondesignsystem.com/components/data-table/usage/

Need explicit guidance for creating content for data tables.

@lesnider
Copy link
Contributor Author

lesnider commented Sep 2, 2024

@sstrubberg @laurenmrice @aagonzales

Hey, Scott, Lauren, and Ann. Here's most of our feedback for the Data table component, which we want to go through with you and other CDSers on Tuesday.
Data_table-UIContentGuild-comments+edits.docx

@laurenmrice
Copy link
Member

Issue refinement

  • I went through the attached document above. I made some comments in it here:
  • Most changes mentioned in the document are doable as part of this issue and I would size it as an 8. However there were a couple things that would need to be addressed in separate issues, which I will list below.

Separate issues

Separate issues would need to be created to tackle the following:

1. Live demo changes

  • PB: The Dropdowns in Variant Selector do not all contain explanations, indicating differences. Batch Actions has lorem ipsum text.
  • List items should be in sentence-style capitalization

These above points would need to be listed in separate issue created in the carbon repo for dev. This needs to first be resolved in the storybook, and then it will be fixed in the live demos on the website.

2. Accessibility testing status changes

  • We're wondering if it's important to have this Accessibility section on every Usage tab, when there is an Accessibility tab
  • Also, per the anchor link section at the top, Accessibility testing status is a subsection of Live demo, which doesn't make sense. Either make it a top level section or remove it

This hierarchical change of where this section appears on the Usage tab would need to put in a separate issue in the carbon-website repo because the outcome of this decision will affect all Usage tabs for components. And yes, this section needs to be on every Usage tab. In the issue, it would be good to suggest alternative solutions of where to place this information and make sure it would scale well across all components.

@laurenmrice laurenmrice moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Sep 17, 2024
@crlordan
Copy link
Contributor

crlordan commented Oct 4, 2024

The document lists that the gutter modes link is broken. This was something we found during our initial investigation. I fixed the link in this PR: #4194

@crlordan
Copy link
Contributor

crlordan commented Oct 15, 2024

PR #4312 has these changes from the Data Table feedback:

  • Copy edits for the Universal Behaviors section.
  • Added a subhead to the entry in the Modifiers section, to match other components and label the modified more clearly.

@aagonzales aagonzales linked a pull request Oct 30, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
6 participants