Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to TimePicker usage in DatePicker usage.mdx #3783

Closed
wants to merge 1 commit into from
Closed

Fix link to TimePicker usage in DatePicker usage.mdx #3783

wants to merge 1 commit into from

Conversation

malachiAeroqual
Copy link

Current link is missing the /components portion of the link and instead takes the user to a 404 page

Changelog

Changed

  • date-picker usage link to time-pickers fragment within page

@malachiAeroqual
Fix link to TimePicker usage in DatePicker usage.mdx
dbcc592 
Current link is missing the `/components` portion of the link and instead takes the user to a 404 page
@malachiAeroqual malachiAeroqual requested review from a team as code owners October 19, 2023 20:17
@vercel
Copy link

vercel bot commented Oct 19, 2023

@malachiAeroqual is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@malachiAeroqual
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

aagonzales
aagonzales approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the fix!

@malachiAeroqual
Copy link
Author

Looks like someone saw this fix and merged it themselves. The website has been updated with the correct link now. Closing this

@malachiAeroqual malachiAeroqual deleted the patch-1 branch October 23, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

@andreancardona andreancardona Awaiting requested review from andreancardona andreancardona was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malachiAeroqual @aagonzales