Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-started.mdx #3766

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Update get-started.mdx #3766

merged 4 commits into from
Oct 31, 2023

Conversation

jeanservaas
Copy link
Collaborator

@jeanservaas jeanservaas commented Oct 6, 2023

Few type changes:

Removed the "Create" under Shankar's contribution description. No one else had a verb.

Also under Review and Publish, I removed "to be made" to streamline the sentence.

Maintainers will be reviewing your work and making comments, asking questions and suggesting changes to be made before they merge your code.

Few type changes
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 4:52pm

@@ -66,7 +66,7 @@ Accessibility<br /><br /> **Amaya Mali**<br /> Gantt chart
<Column className="one" colSm={2} colMd={2} colLg={3}>

**Tom Roach**<br /> Community support<br /><br />**Eugene To **<br />
Figma<br /><br /> **Shankar Venkatachalam** <br /> Create React App<br /><br />
Figma<br /><br /> **Shankar Venkatachalam** <br /> React App<br /><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Create React App" is the correct name I believe https://create-react-app.dev/ (not sure where the Carbon version is)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanservaas See alison's comment here. Does this need an update?

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kodiakhq kodiakhq bot merged commit b905727 into main Oct 31, 2023
6 checks passed
@kodiakhq kodiakhq bot deleted the jeanservaas-patch-1 branch October 31, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants