-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get-started.mdx #3766
Update get-started.mdx #3766
Conversation
Few type changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -66,7 +66,7 @@ Accessibility<br /><br /> **Amaya Mali**<br /> Gantt chart | |||
<Column className="one" colSm={2} colMd={2} colLg={3}> | |||
|
|||
**Tom Roach**<br /> Community support<br /><br />**Eugene To **<br /> | |||
Figma<br /><br /> **Shankar Venkatachalam** <br /> Create React App<br /><br /> | |||
Figma<br /><br /> **Shankar Venkatachalam** <br /> React App<br /><br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Create React App" is the correct name I believe https://create-react-app.dev/ (not sure where the Carbon version is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanservaas See alison's comment here. Does this need an update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Few type changes:
Removed the "Create" under Shankar's contribution description. No one else had a verb.
Also under Review and Publish, I removed "to be made" to streamline the sentence.
Maintainers will be reviewing your work and making comments, asking questions and suggesting changes to be made before they merge your code.