Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VRT for website #3737

Open
alisonjoseph opened this issue Sep 8, 2023 · 3 comments
Open

Implement VRT for website #3737

alisonjoseph opened this issue Sep 8, 2023 · 3 comments

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Sep 8, 2023

Baseline VRT

  • Homepage ("Latest news and articles" section pulls from medium)
  • Most visited "Guidelines" page
  • guidelines/icons/library (notorious for breaking)
  • guidelines/pictograms/library (notorious for breaking)
  • guidelines/typography/type-sets
  • Most visited "Components" page (usage and accessibility tabs)
  • Most visited "Patterns" page
  • Data viz -> simple charts
  • Contributing page (since this pulls from airtable)

Only ~10 snapshots per PR build and would give us reasonable assurance we didn't totally break anything

@tay1orjones

This comment was marked as outdated.

@tay1orjones
Copy link
Member

Since we reduced Percy usage by ~50% in carbon-design-system/carbon#14779, I think we could do this but we'd need to be mindful of our quota.

@sstrubberg sstrubberg changed the title Explore VRT for website Implement VRT for website Nov 7, 2023
@sstrubberg sstrubberg added this to the 2024 Q1 milestone Nov 7, 2023
@tay1orjones
Copy link
Member

tay1orjones commented Nov 15, 2023

Instead of using playwright for taking and sending the percy snapshots, we could just invoke the percy cli and keep the usage as dead-simple as possible.

@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@tay1orjones tay1orjones modified the milestones: 2024 Q2, 2024 Q3 Jun 19, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Aug 14, 2024
@sstrubberg sstrubberg removed this from the 2024 Q3 milestone Aug 14, 2024
@sstrubberg sstrubberg moved this from Triage to Icebox in Roadmap Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

4 participants