Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox unique value]: Update website docs with unique value #3579

Closed
8 tasks done
Tracked by #6102
laurenmrice opened this issue Jun 2, 2023 · 2 comments · Fixed by #4364
Closed
8 tasks done
Tracked by #6102

[Combobox unique value]: Update website docs with unique value #3579

laurenmrice opened this issue Jun 2, 2023 · 2 comments · Fixed by #4364

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jun 2, 2023

Acceptance criteria

  • Update the Combobox portion of the Usage, Style, and Accessibility tab docs to reflect the new behavior of entering a unique value.
  • Determine if it should be called "unique value" or "custom value". It should be the terminology that is the best practice or most widely known in the industry for this feature. Consult with dev.

Usage tab

Combobox

### Custom value

  • Add a new H3 section heading for entering a custom value. Initial ideas for this name is "Custom value", "Entering a custom value".
  • Add new content and images.

Universal behaviors

Interactions

Keyboard

Combobox:

  • Add written guidance on how to handle keyboard interactions for this if needed in the combobox section.

    Since the Keyboard Interactions section has now been moved from the Usage tab to the Accessibility tab, nothing new will be added under that section.

Style tab

  • Custom value: As far as I can tell, there are no visual differences we need to address on the Style tab for entering a custom value right now, it is more of interaction changes? Need to double check
  • Note: *Eventually there will be an exploration/design spec for improving the visuals of this experience in this umbrella.

Accessibility tab

  • Add written guidance for this under "Keyboard interactions" and provide and image.
  • Add written guidance for this under "Development considerations" if needed.

    Taylor confirmed that there is no need to add any new content.


PR

  • Create PR
  • PR review
@laurenmrice laurenmrice transferred this issue from carbon-design-system/carbon Jun 2, 2023
@laurenmrice laurenmrice added this to the 2023 Q2 milestone Jun 2, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Jun 2, 2023
@laurenmrice laurenmrice moved this to ⏱ Backlog in Design System Jun 2, 2023
@thyhmdo thyhmdo self-assigned this Jun 9, 2023
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Jun 13, 2023
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Jun 15, 2023
@tay1orjones tay1orjones moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Jun 15, 2023
@laurenmrice laurenmrice moved this from ⏱ Backlog to 🏗 In Progress in Design System Jun 26, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q2, 2023 Q4 Oct 2, 2023
@laurenmrice laurenmrice moved this from 🏗 In Progress to ⏱ Backlog in Design System Dec 12, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q4, 2024 Q1 Jan 9, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@laurenmrice laurenmrice changed the title Combobox unique value: update website docs Combobox unique value: Update website docs with unique value Jun 12, 2024
@laurenmrice laurenmrice moved this from Now to Later in Roadmap Jun 12, 2024
@laurenmrice laurenmrice changed the title Combobox unique value: Update website docs with unique value [Combobox unique value]: Update website docs with unique value Jun 12, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q2, 2024 Q3 Jun 13, 2024
@sstrubberg sstrubberg moved this from Later to Now in Roadmap Jun 27, 2024
@laurenmrice laurenmrice moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Sep 5, 2024
@sstrubberg sstrubberg removed this from Roadmap Sep 27, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 27, 2024
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Oct 2, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 moved this from ⏱ Backlog to 🏗 In Progress in Design System Nov 7, 2024
@Kritvi-bhatia17
Copy link
Contributor

After discussing with the team and reviewing industry standards, where both Elastic and Adobe refer to the feature as 'custom value', it seems to be the best choice, as it also aligns with our Storybook documentation.

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented Nov 14, 2024

Figma file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment