Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dropdown] updates to usage and style guidance #2123

Closed
4 tasks done
laurenmrice opened this issue Feb 4, 2021 · 0 comments · Fixed by #2127
Closed
4 tasks done

[dropdown] updates to usage and style guidance #2123

laurenmrice opened this issue Feb 4, 2021 · 0 comments · Fixed by #2127
Assignees
@laurenmrice
Labels
component: combobox component: dropdown role: content 📝 type: bug 🐛

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Feb 4, 2021 •
edited
Loading

Usage tab

  • Combobox: Edit out all guidance about adding unique entries. Our combobox currently does not have this functionality. We can update this again once #6102 is added to code.

  • Dropdown: Remove optional when talking about visual labels.

  • Dropdown: Split up label and helper-text under the anatomy section to expand more on our guidance.

Style tab

  • Update focus states for open menus. There should be a 1px focus on the open menu container and not on individual items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurenmrice laurenmrice

Labels
component: combobox component: dropdown role: content 📝 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(dropdown): usage and style updates laurenmrice/carbon-website
1 participant
@laurenmrice