Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e testing to focus on percy snapshot testing for Web Components #5612

Closed
2 tasks
jeffchew opened this issue Mar 25, 2021 · 3 comments
Closed
2 tasks
Labels
dev Needs some dev work icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: web components Work necessary for the IBM.com Library web components package priority: medium

Comments

@jeffchew
Copy link
Member

User Story

As a [user role below]:
Carbon for IBM.com tester

I need to:
see automated visual regression tests against knob variations of storybook stories in Web Components

so that I can:
properly test additional states of components in Browserstack/Percy

Additional information

Acceptance criteria

  • Updated harness to have working snapshots of percy tests in Web Components
  • Hook up CI pipeline for e2e tests to generate for Web Components
@jeffchew jeffchew added dev Needs some dev work priority: medium package: web components Work necessary for the IBM.com Library web components package labels Mar 25, 2021
@jeffchew jeffchew added this to the Sprint 21-07 milestone Mar 25, 2021
@jeffchew jeffchew self-assigned this Mar 25, 2021
@jeffchew
Copy link
Member Author

jeffchew commented Apr 6, 2021

Taking a look at this, and discovering that this may be a limitation on how the DOM is captured in Percy, serialized, and sent to the Percy build. I added a comment to the following existing issue found under @percy/dom within their CLI:

percy/cli#280

The only workaround I found was to set enableJavascript to true, which does seem to render the shadow DOM content. However, it does not seem to capture any interactive states on the page. This includes clicking menus, entering in search forms, etc.

We could feasibly focus on non-interactive snapshots like theming, knob settings, etc. Or we can shelve this entirely until the feature is available from Percy.

@jeffchew jeffchew added the icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. label Apr 7, 2021
@jeffchew
Copy link
Member Author

jeffchew commented Apr 7, 2021

@RobertaJHahn , we have decided to icebox this for now until we can get a full fledge solution from Percy for this.

@RobertaJHahn
Copy link

Done. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: web components Work necessary for the IBM.com Library web components package priority: medium
Projects
None yet
Development

No branches or pull requests

2 participants