Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Fix inconsistent state transitions for all variants #842

Closed
6 tasks done
laurenmrice opened this issue Jul 1, 2024 · 2 comments
Closed
6 tasks done

[Dropdown] Fix inconsistent state transitions for all variants #842

laurenmrice opened this issue Jul 1, 2024 · 2 comments

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jul 1, 2024

Acceptance criteria

  • After the auditing in issue #818, fix the following interaction state transition bugs below that are occurring in Dropdown, Multiselect, and Combobox.

  • There is a Figma branch created for this that you can use for this work.


Filterable Multiselect (default style)

Selected state

  • Toggling on "Selected" transitions to the "Read-only selected state" instead of keeping it in the "Enabled selected state".
  • Toggling off "Selected" transitions to the "Read-only enabled state" rather than just returning to the "Enabled" state.

Dropdown (fluid style)

Enabled state

  • Toggling on "Open" transitions to the "Focused selected", but closing it returns to "Focused (Collapsed)". It should just transition to the "Enabled open state" with focus on the field.

Dropdown (default style)

Selected state

  • Toggling on "Open" and then toggling on “Selected” the top field indicates that an option has been selected which is correct, but the option in the menu that is selected does not have a background color change or checkmark icon indicator.

Combobox (default style)

Error state

  • When you open the Combobox, it directly puts you into an error state. This should not be an error state and is causing confusion to our users.

error combobox


Multi variants

  • Focus state options were missing in many variants ---> Reset and changed to the correct state while turning on the border

@laurenmrice
Copy link
Member Author

Blocked on starting this issue until combobox work is completed and implemented on the dev side, because it could affect the final specs of focus states (#6102)

@laurenmrice laurenmrice modified the milestones: 2024 Q3, 2024 Q4 Sep 19, 2024
@sstrubberg
Copy link
Member

sstrubberg commented Nov 13, 2024

Waiting for Combobox work to finish.

@thyhmdo thyhmdo moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Nov 20, 2024
@thyhmdo thyhmdo self-assigned this Dec 10, 2024
@laurenmrice laurenmrice moved this from ⏱ Backlog to 🚦 In Review in Design System Dec 11, 2024
@thyhmdo thyhmdo closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants