-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Apt debian packages #2541
[Draft] Apt debian packages #2541
Conversation
…thing is working as intended
At the moment, I get /usr/local/lib/libcapstone.so.6.0. My question is, where is the .so.6.0 being populated? Should a fix be made to have the files only be in a format like libcapstone.so.5, libcapstone.so.6, etc? With that said, I will have to assume the version based as an argument is correct in populating the control file |
I suspect I also need to update capstone.pc to point from /usr/local to /usr? Once again, the main question is how would the plan be to update these new packages to Ubuntu/Debian. |
You can check the Debian package naming conventions for details. The revision version must be part of the name apparently (docs, dpkg-name and more details).
As I see it, it should install directly into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all packaging related files into packages/deb/
@AndrewQuijano I looked into your questions in detail and found actually more than one problem. I am sorry that I did not review more thoroughly before. I also never worked with The issues I found are the following:
I tried fixing some of them, but quickly recognized that it gets out of hand quickly. And for Capstone we need a more complete approach. As it looks like, the original script, you used as a basis, was never meant to generate a Unfortunately, we cannot provide a package which is this much incomplete for the release. In #2543 I removed it from the release CI, but kept your work in Because your initial idea was to ease the install in PANDA, I would see two solutions for this:
I am sorry again I didn't properly reviewed the first PR, due to my lag of knowledge about Debian packages. |
Your checklist for this pull request
Detailed description
Based on the original PR #2521, I created a Debian package that created everything needed to run capstone. However, it would be nice to be able to update the Debian package repositories too. So I will be working on the steps to create the updated libcapstone5, libcapstone6, and libcapstone-dev packages to be relatively identical to the current outdated versions in Ubuntu.
...
Test plan
Based on a prior PR, I am essentially using these same tests to confirm the packages that would be sent to Debian/Ubuntu work as intended.
...
Closing issues
closes #2537
...