Skip to content
This repository has been archived by the owner on Aug 7, 2019. It is now read-only.

Feature: Pull Requests #128

Open
jonsharratt opened this issue Jan 24, 2013 · 1 comment
Open

Feature: Pull Requests #128

jonsharratt opened this issue Jan 24, 2013 · 1 comment

Comments

@jonsharratt
Copy link
Contributor

Hi @caolan,

If you get a moment I have started putting together a feature that you may or may not agree with. It has become apparent there is a bit of a blocking issue when other contributors wish for a repository to be updated.

I have a commit that starts and fundamentally works in which anyone will be able to submit a pull request for a package, using commands as follows:

jam pullrequest PACKAGE_FOLDER
jam pullrequest PACKAGENAME@VERSION --accept

Current code can be found at:
redbadger@31acaa0

I have this working with integration tests but need some help in getting my local testing couchdb environment setup so that the permissions react in the same way. This means for owners I can ensure the code will work when a non owner tries to publish a pull request against a package they do not own and also when a non owner of the package for a pull request accept may happen.

Any thoughts or feedback on whether you or anyone else thinks this feature would be helpful would be appreciated.

Look forward to hearing from you.

@caolan
Copy link
Owner

caolan commented Feb 5, 2013

Interesting idea, how would you alert the package owner that there is a pull request pending? Currently the website doesn't send any emails but it might be a good idea in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants