Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mone in generator #32

Open
udion opened this issue Mar 13, 2018 · 1 comment
Open

mone in generator #32

udion opened this issue Mar 13, 2018 · 1 comment

Comments

@udion
Copy link

udion commented Mar 13, 2018

Hi,
In the gan training code, since you have already used gen_cost.backward(mone) for generator, why are you still doing gen_cost = -gen_cost

i.e, should it not be

  • just gen_cost.backward(mone)
    or
  • gen_cost.backward() and then gen_cost = gen_cost*-1
    Please correct me if I am wrong.
@bsridatta
Copy link

shouldnt it be 1 instead of -1, the generator should learn to output such a way that the crtiic believes there are real i.e 1 and not -1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsridatta @udion