fix(unsquashfs): fix Fatal Error when using unsquashfs #5147
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5147 +/- ##
==========================================
- Coverage 94.88% 89.70% -5.18%
==========================================
Files 658 341 -317
Lines 55189 22587 -32602
==========================================
- Hits 52364 20261 -32103
+ Misses 2825 2326 -499 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@sergio-costas, thanks for the PR! I'm wondering if this will get fixed for free when we update snapcraft itself to core24 in #5136, which should grab squashfs-tools 4.6.1.
|
@mr-cal I presume that yes, that would be the case, so this is just an interim solution while snapcraft isn't migrated. |
|
According to Ken, it also fixes the ARM problem. |
When trying to push a big snap, snapcraft fails with the error
FATAL ERROR: Data queue size is too large
This is a bug in unsquashfs tool 4.5. But it has been fixed in
4.6.1, the current stable.
This patch builds squashfs-tools version 4.6.1 from the GIT
repository, thus fixing this problem.
Fix canonical#5132
sergio-costas
force-pushed
the
fix-unsquashfs-bug-data-queue-too-large
branch
from
778bdf0 to
a678e5d
Compare
|
@mr-cal I see that the migration to Core24 is still a draft, so it probably will require some time to be merged and published. This one, instead, fixes the problem right now. And in the Core24 migration PR, you can just remove the squashfs part after rebasing, to use again the updated .deb version... |
|
(in fact, I'm having this problem right now with another snap... and it isn't even as big as the previous one) |
Hi, sorry about the delay here. I'm planning to complete the core24 migration in the next 2 weeks if our team planning goes smoothly. With either that core24 PR or this PR, a newer version of squashfs tools will have to go into the 8.7.x release series, which won't be until 2025-Jan at the earliest. |
|
Oh... that makes sense, yes. I'll close this, then. |
|
Yeah, I apologize for the overlap here - there have been a bunch of moving parts in snapcraft releases recently. I very much appreciate the PR and your testing - I wouldn't have been able to test this on my own. |
When trying to push a big snap to the snap store, snapcraft fails with the error
This is a bug in unsquashfs tool 4.5. But it has been fixed in 4.6.1, the current stable.
This patch builds squashfs-tools version 4.6.1 from the GIT repository, thus fixing this problem.
Fix #5132
Fix https://forum.snapcraft.io/t/fatal-error-data-queue-size-is-too-large/43875
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)