From 8990337308e7b8cecffdfff42c67ee49e2029812 Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 13:42:38 +0300 Subject: [PATCH 1/8] feat(docs): Add vale style checker --- .github/workflows/test.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 5a0931f3..b13e5292 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -93,6 +93,29 @@ jobs: filter-mode: nofilter workdir: ${{ inputs.working-directory }} woke-version: latest + vale: + name: Style checker + runs-on: >- + ${{ + inputs.self-hosted-runner && + fromJson(format('[''self-hosted'', ''{0}'', ''{1}'', ''{2}'']', + inputs.self-hosted-runner-arch, inputs.self-hosted-runner-label, inputs.self-hosted-runner-image + )) || 'ubuntu-22.04' + }} + defaults: + run: + shell: bash + working-directory: ${{ inputs.working-directory }} + steps: + - name: Checkout repo to runner + uses: actions/checkout@v3 + - name: Install styles + uses: canonical/praecepta@main + - name: Run Vale tests + uses: errata-ai/vale-action@reviewdog + with: + files: ./docs + fail_on_error: false shellcheck-lint: name: Shell scripts lint runs-on: >- From 689545e15bfa67c905c5ffdb459618ca20834343 Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 15:28:34 +0300 Subject: [PATCH 2/8] chore(): Use pinned checkout --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index b13e5292..bd2bf19a 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -108,7 +108,7 @@ jobs: working-directory: ${{ inputs.working-directory }} steps: - name: Checkout repo to runner - uses: actions/checkout@v3 + uses: actions/checkout@v4.1.7 - name: Install styles uses: canonical/praecepta@main - name: Run Vale tests From c58f49ce169e0665329f88cc094500f1476f159b Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 15:39:48 +0300 Subject: [PATCH 3/8] chore(): Install tree for github runners --- .github/workflows/test.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index bd2bf19a..380c27aa 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -111,6 +111,8 @@ jobs: uses: actions/checkout@v4.1.7 - name: Install styles uses: canonical/praecepta@main + run: | + apt-get update -y && apt-get install -y tree - name: Run Vale tests uses: errata-ai/vale-action@reviewdog with: From 0c20adaf66a45cbaefa9d835f569bc4d6fd638e8 Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 16:14:28 +0300 Subject: [PATCH 4/8] chore(): Run forrest run --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 380c27aa..887bf7f5 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -111,7 +111,7 @@ jobs: uses: actions/checkout@v4.1.7 - name: Install styles uses: canonical/praecepta@main - run: | + - run: | apt-get update -y && apt-get install -y tree - name: Run Vale tests uses: errata-ai/vale-action@reviewdog From 4c64c17a04fbdd5d2bbfe05f43a00ef3cc477d9e Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 16:23:16 +0300 Subject: [PATCH 5/8] chore(): Sudo make me a sandwich --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 887bf7f5..5158776f 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -112,7 +112,7 @@ jobs: - name: Install styles uses: canonical/praecepta@main - run: | - apt-get update -y && apt-get install -y tree + sudo apt-get update -y && sudo apt-get install -y tree - name: Run Vale tests uses: errata-ai/vale-action@reviewdog with: From cf3b5f382102efdde712525175de787ba7dba416 Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 16:39:11 +0300 Subject: [PATCH 6/8] =?UTF-8?q?chore():=20=C2=AF\=5F(=E3=83=84)=5F/=C2=AF?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/test.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 5158776f..1193eb43 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -109,10 +109,10 @@ jobs: steps: - name: Checkout repo to runner uses: actions/checkout@v4.1.7 - - name: Install styles - uses: canonical/praecepta@main - run: | sudo apt-get update -y && sudo apt-get install -y tree + - name: Install styles + uses: canonical/praecepta@main - name: Run Vale tests uses: errata-ai/vale-action@reviewdog with: From d34cc01ce1128b8745601b4b0185134a6c0cf52f Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Tue, 24 Sep 2024 17:35:59 +0300 Subject: [PATCH 7/8] chore(): Needs rubygems --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 1193eb43..1a0f1ae0 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -110,7 +110,7 @@ jobs: - name: Checkout repo to runner uses: actions/checkout@v4.1.7 - run: | - sudo apt-get update -y && sudo apt-get install -y tree + sudo apt-get update -y && sudo apt-get install -y tree ruby-rubygems - name: Install styles uses: canonical/praecepta@main - name: Run Vale tests From f25334fa1c8c31c9cd0603dc203b2270b38bd651 Mon Sep 17 00:00:00 2001 From: Mariyan Dimitrov Date: Fri, 11 Oct 2024 17:12:54 +0300 Subject: [PATCH 8/8] Update test.yaml Co-authored-by: Christopher Bartz Signed-off-by: Mariyan Dimitrov --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 14c7a3d1..d1de3c0f 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -116,7 +116,7 @@ jobs: - name: Run Vale tests uses: errata-ai/vale-action@reviewdog with: - files: ./docs + files: ${{ inputs.charm-directory }}/docs fail_on_error: false shellcheck-lint: name: Shell scripts lint