Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlr_layer_shell_surface::set_size does not respect 0-sized widths and heights properly #3678

Open
mattkae opened this issue Nov 22, 2024 · 2 comments
Labels

Comments

@mattkae
Copy link
Contributor

mattkae commented Nov 22, 2024

According to the wlr layer shell protocol specification:

If you pass 0 for either value, the compositor will assign it and inform you of the assignment in the configure event. You must set your anchor to opposite edges in the dimensions you omit; not doing so is a protocol error. Both values are 0 by default.

reference: https://wayland.app/protocols/wlr-layer-shell-unstable-v1#zwlr_layer_surface_v1:request:set_size

Instead, this value appears to remain 0 such that when we hit BasicWindowManager::validate_modification_request we fail validation, which results in an error.

This error was encountered when running cosmic-panel.

@mattkae mattkae added the bug label Nov 22, 2024
@AlanGriffiths
Copy link
Collaborator

Good find! That makes sense of what we've been seeing!

@AlanGriffiths
Copy link
Collaborator

Mentioning #3675 and #3676: this might make them moot, but they may also contain parts of the right behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants