Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charms won't override existing state if changed #551

Open
kimwnasptd opened this issue Sep 9, 2024 · 1 comment
Open

Charms won't override existing state if changed #551

kimwnasptd opened this issue Sep 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

kimwnasptd commented Sep 9, 2024

Bug Description

This is a follow-up from #549

We saw that, for some reason, the istio-validator-{model} ValidationWebhookConfiguration contain incorrectly formed data that redirected to a K8s svc that belonged to a different namespace.

Yet, the reconciliation loop of the Charm did not pick this up and overwrite the ValidationWebhookConfiguration to have the correct SVC

Expected behavior

  • The Charm should override any Istio resource to the expected value (not only ValidationWebhookConfiguration)

To Reproduce

  1. Deploy the Istio charms
  2. Manually edit the ValidationWebhookConfiguration above (cluster scoped)
  3. Change the k8s svc used in the webhook to a random value

The Charm will never update the webhook with the correct value afterwards

Environment

Istio Charms from track/1.22

Relevant Log Output

<none>

Additional Context

We saw this happen because Istio was not removed properly.

Still it's not clear how we ended up having a istio-validator-kubeflow ValidationWebhookConfiguration object that pointed to istio-validator-kubeflow-dev (since it looks like values from different models were used)

@kimwnasptd kimwnasptd added the bug Something isn't working label Sep 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6212.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant