Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace requests-unixsocket with requests-unixsocket2 #852

Closed
lengau opened this issue Sep 23, 2024 · 1 comment · Fixed by #853
Closed

replace requests-unixsocket with requests-unixsocket2 #852

lengau opened this issue Sep 23, 2024 · 1 comment · Fixed by #853
Assignees
@lengau
Labels
Enhancement New feature or request Triaged

Comments

@lengau
Copy link
Contributor

lengau commented Sep 23, 2024 •
edited
Loading

What needs to get done

  • Write tests that test success/failure of talking to snapd
  • Replace the dependency on requests-unixsocket with requests-unixsocket2: https://gitlab.com/thelabnyc/requests-unixsocket2
  • Update to the latest requests
  • Backport this change to supported versions
  • Make downstream bugfix updates in relevant crafts

Why it needs to get done

requests-unixsocket appears to be a dead project, with the last commit 3 years ago. There has been an open PR for several months to fix an issue that prevents us from updating to requests 2.32 or later.
@lengau lengau added Enhancement New feature or request Triaged labels Sep 23, 2024
@lengau lengau self-assigned this Sep 23, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3439.

This message was autogenerated

lengau added a commit that referenced this issue Sep 23, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unisocket2
3657f9d 
Fixes #852
lengau added a commit that referenced this issue Sep 23, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
52b4f30 
Fixes #852
lengau added a commit that referenced this issue Sep 23, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
f5101c0 
Fixes #852
lengau added a commit that referenced this issue Sep 23, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
72cec7f 
Fixes #852
@lengau lengau linked a pull request Sep 23, 2024 that will close this issue
build(deps): replace requests-unixsocket with requests-unixsocket2 #853
Merged
1 task
lengau added a commit that referenced this issue Sep 24, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
0ffdad8 
Fixes #852
lengau added a commit that referenced this issue Sep 24, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
d85c5ab 
Fixes #852
lengau added a commit that referenced this issue Sep 30, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
778e29d 
Fixes #852
lengau added a commit that referenced this issue Oct 1, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
33f25d1 
Fixes #852
lengau added a commit that referenced this issue Oct 2, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
3ee18e4 
Fixes #852
lengau added a commit that referenced this issue Oct 2, 2024
@lengau
build(deps): replace requests-unixsocket with requests-unixsocket2
73e64b9 
Fixes #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengau lengau

Labels
Enhancement New feature or request Triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): replace requests-unixsocket with requests-unixsocket2 canonical/craft-parts
1 participant
@lengau