Support watchNamespace for controller #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jayesh-srivastava Please rebase on latest As for the PR, it looks OK, I imagine we would need a similar PR on https://github.com/canonical/cluster-api-bootstrap-provider-microk8s/ |
jayesh-srivastava
force-pushed
the
support-watchnamespace
branch
from
23e2e8a to
51605fe
Compare
jayesh-srivastava
force-pushed
the
support-watchnamespace
branch
from
51605fe to
e014e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds support for watchNamespace flag for control-plane-microk8s controller which will restrict the controller to watch cluster-api objects in its namespace only. This is beneficial for certain downstream use cases where there is a separation between controllers and webhooks and one controller is used per namespace.
Which issue(s) this PR fixes:
Fixes #50