feat: add support for hard links #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard links can now be extracted and they are correctly reflected in the manifest. --------- Co-authored-by: Rafid Bin Mostofa <[email protected]> Co-authored-by: Alberto Carretero <[email protected]>
niemeyer
requested changes
Dec 16, 2024
internal/deb/extract.go
Outdated
|
|
||
| // sanitizeTarPath removes the leading "./" from the source path in the tarball, | ||
| // and verifies that the path is not empty. | ||
| func sanitizeTarPath(path string) string { |
There was a problem hiding this comment.
Do we have any logic that prevents the tar from leaving the target directory?
There was a problem hiding this comment.
No, we don't at the moment.
There was a problem hiding this comment.
Agreed offline to do it, just not in this PR.
niemeyer
approved these changes
Jan 10, 2025
internal/deb/extract.go
Outdated
| } | ||
| } | ||
| sort.Strings(errs) | ||
| return fmt.Errorf("%s", errs[0]) |
There was a problem hiding this comment.
Per comment in the prior review, we don't need to append all the errors to then return the first one. We can simply stop on the first thing we find and return the error.
There was a problem hiding this comment.
The problem with that is that the error won't be deterministic, right? Maybe we can sort the links instead of the error if that is more performant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard links can now be extracted and they are correctly reflected in the manifest.