Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port forward recent 24.04 additions to 24.10 branch #391

Open
HadrienPatte opened this issue Nov 18, 2024 · 4 comments
Open

Port forward recent 24.04 additions to 24.10 branch #391

HadrienPatte opened this issue Nov 18, 2024 · 4 comments
Assignees

Comments

@HadrienPatte
Copy link
Contributor

The ubuntu-24.10 branch has been available and ready for a couple of weeks now, but a couple of PRs targeting the ubuntu-24.04 branch have been merged since and have not been port forwarded, leading to some SDFs being available in 24.04 and not in 24.10.
Over time this will cause issues, see CONTRIBUTING.md:

To enforce consistency across the different chisel releases, every slice definition that is proposed for a given chisel release MUST also be proposed for all newer and still supported chisel releases

The goal of this issue is to track all PRs that need to be port-forwarded to the 24.10 branch. Those are as follows (in order of merge to the 24.04 branch):

24.04 PR 24.10 PR
#364 TODO
#220 TODO
#350 TODO
#349 TODO
#360 TODO
#375 #376
#370 #371
#341 TODO
#324 TODO
#359 TODO
#314 TODO
@cjdcordeiro
Copy link
Collaborator

Thank you very much for helping keep track of these @HadrienPatte !

We're already working on porting these internally, but we'd be happy get them contributed too, so pls let us know if you're planning on addressing any of those :)

@cjdcordeiro
Copy link
Collaborator

quick update: these are being proposed in #392

@cjdcordeiro
Copy link
Collaborator

Thanks for porting those @HadrienPatte . They've been merged and we'll be adding some checks in the future to try to flag such cases during the opening of a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants