Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bindingType for called processes/decisions/forms #4385

Closed
6 tasks done
jfriedenstab opened this issue Jun 19, 2024 · 6 comments · Fixed by #4439
Closed
6 tasks done

Support bindingType for called processes/decisions/forms #4385

jfriedenstab opened this issue Jun 19, 2024 · 6 comments · Fixed by #4439
Assignees
Labels
BPMN Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request
Milestone

Comments

@jfriedenstab
Copy link

jfriedenstab commented Jun 19, 2024

Problem you would like to solve

As a Camunda 8 user, when I design a BPMN process, I'd like to be able to choose between the binding types latest and deployment for called processes, called decisions and linked forms. I would also like to understand the differences between them so I can pick the right one for my use case.

Proposed solution

  • Add a new dropdown "Binding" with the options latest and deployment to the properties panel:
    • to the "Called element" section for a call activity
    • to the "Called decision" section for a business rule task (below "Decision ID")
    • to the "Form" section for a user task; the dropdown must only be displayed in the following cases (for the other ones, the binding type is not applicable):
      • implementation type: Zeebe user task + form type: Camunda Form
      • implementation type: Job Worker + form type: Camunda Form (linked)
  • Add a tooltip for the dropdown which explains the different options.
  • We validate the binding type using our usual infrastructure (Validate bindingType property (supported in Camunda 8.6+) #4386)

Implementation Notes

  • The binding type should be stored in the new attribute bindingType in the diagram's XML:
    <zeebe:calledElement processId="test-process" bindingType="deployment" ... />
    <zeebe:calledDecision decisionId="test-decision" bindingType="deployment" ... />
    <zeebe:formDefinition formId="test-form" bindingType="deployment" ... />
  • If the attribute is not set, select latest as the default option.

Alternatives considered

None.

Additional context

@jfriedenstab jfriedenstab added the enhancement New feature or request label Jun 19, 2024
@jfriedenstab jfriedenstab added Camunda 8 Flags an issue as related to Camunda 8 BPMN labels Jun 19, 2024
@nikku nikku changed the title Add binding type dropdown for called processes/decisions/forms in C8 diagrams Support bindingType for called processes/decisions/forms Jun 20, 2024
@nikku
Copy link
Member

nikku commented Jun 20, 2024

Thanks @jfriedenstab. Tagged for 8.6.

Following our normal procedures we'll work on this once the respective feature is merged in Zebee.

@nikku nikku added this to the 8.6 milestone Jun 20, 2024
@nikku nikku added the backlog Queued in backlog label Jun 20, 2024
@nikku nikku modified the milestones: 8.6, ready Jul 3, 2024
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 3, 2024
@nikku
Copy link
Member

nikku commented Jul 3, 2024

This is scheduled on the run-time side of things for 8.6-alpha4. Let's see if we can support it in the modelers at the same time.

@philippfromme philippfromme self-assigned this Jul 16, 2024
@philippfromme
Copy link
Contributor

Question: If the bindingType attribute is missing, is latest assumed?

@jfriedenstab
Copy link
Author

@philippfromme Yes, exactly.

@philippfromme
Copy link
Contributor

@philippfromme Yes, exactly.

Sorry, found it in the original issue. 😅

philippfromme added a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 19, 2024
philippfromme added a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 19, 2024
philippfromme added a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 22, 2024
@philippfromme philippfromme added the in progress Currently worked on label Jul 23, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the ready Ready to be worked on label Jul 23, 2024
philippfromme added a commit to camunda/camunda-bpmn-js-behaviors that referenced this issue Jul 24, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 24, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 25, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 25, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 25, 2024
philippfromme added a commit to camunda/camunda-bpmn-js-behaviors that referenced this issue Jul 26, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 26, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 29, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 29, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 29, 2024
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Jul 29, 2024
@barmac
Copy link
Collaborator

barmac commented Aug 1, 2024

This is fixed upstream. incomplete right now due to missing #4386.

@barmac barmac added fixed upstream Requires integration of upstream change ready Ready to be worked on and removed in progress Currently worked on fixed upstream Requires integration of upstream change labels Aug 1, 2024
barmac added a commit that referenced this issue Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Aug 1, 2024
barmac added a commit that referenced this issue Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 1, 2024
@github-actions github-actions bot added this to the M79 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants