-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create/append search should prefer items starting with typed text #3439
Comments
CC @smbea I found the same thing, trying to search for |
Makes a lot of sense |
Will assign to me so I can look at this |
I wonder what should happen regarding the groups (namely templates group). Let's say we have a popup menu like: "Rule template" would be prioritized given that it starts with "rule". Would we prioritize the whole group or prioritize it within its group? Another option would be to omit the groups during search |
Good question. Maybe it makes sense to look at this in a more holistic manner; consider group names, too, and consider display (with group headers or not)? An (simple) alternative would be to only match from the start of a token; from what I understand this is what @barmac stumbled upon. One assumption I have (not tested) is that re-ordering elements in the search results will confuse me. |
CC @YanaSegal. Maybe you have some general UX insights to share. |
Me and @YanaSegal discussed this topic yesterday and ended up discussing how the search could work in a more general aspect.
With this discussion, the capability of collapsing/expanding groups also came up. I created a separate issue for this: bpmn-io/diagram-js#764 |
Depends on camunda/camunda-bpmn-js#393 to be released and incorporated. |
Unfortunately not fully addressed via #4711 (yet): (Fails with |
I looked into this again, via bpmn-io/diagram-js#953. First I thought that it would be unexpected that we still group search results (while the results are actually in a chaotic order). However #3439 (comment) backed up that we want to:
➡️ This is what we do today, and will ship, cf. bpmn-io/diagram-js#953. |
CC @lmbateman regarding #3439 (comment) and #3439 (comment). |
Problem you would like to solve
I was surprised to discover that I have to scroll the menu to find End Event after typing "en", even though it's the only element which starts with "en". IMO it should be on top of the list.
Screen.Recording.2023-02-09.at.10.50.08.mov
Proposed solution
If an item starts with the searched text, it should appear on top.
Alternatives considered
Leave it as is.
Additional context
No response
The text was updated successfully, but these errors were encountered: