Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/append search should prefer items starting with typed text #3439

Closed
barmac opened this issue Feb 9, 2023 · 11 comments · Fixed by #4711
Closed

Create/append search should prefer items starting with typed text #3439

barmac opened this issue Feb 9, 2023 · 11 comments · Fixed by #4711
Assignees
Labels
BPMN enhancement New feature or request modeling spring cleaning Could be cleaned up one day ux
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 9, 2023

Problem you would like to solve

I was surprised to discover that I have to scroll the menu to find End Event after typing "en", even though it's the only element which starts with "en". IMO it should be on top of the list.

Screen.Recording.2023-02-09.at.10.50.08.mov

Proposed solution

If an item starts with the searched text, it should appear on top.

Alternatives considered

Leave it as is.

Additional context

No response

@barmac barmac added modeling enhancement New feature or request labels Feb 9, 2023
@nikku
Copy link
Member

nikku commented Feb 9, 2023

CC @smbea I found the same thing, trying to search for ter (Terminiate End Event).

@smbea
Copy link
Contributor

smbea commented Feb 9, 2023

Makes a lot of sense

@smbea
Copy link
Contributor

smbea commented Feb 9, 2023

Will assign to me so I can look at this

@smbea smbea self-assigned this Feb 9, 2023
@smbea smbea added the backlog Queued in backlog label Feb 9, 2023
@smbea
Copy link
Contributor

smbea commented Mar 16, 2023

I wonder what should happen regarding the groups (namely templates group). Let's say we have a popup menu like:

Screenshot 2023-03-16 at 11 56 56

"Rule template" would be prioritized given that it starts with "rule". Would we prioritize the whole group or prioritize it within its group? Another option would be to omit the groups during search

@nikku
Copy link
Member

nikku commented Mar 17, 2023

Good question. Maybe it makes sense to look at this in a more holistic manner; consider group names, too, and consider display (with group headers or not)?

An (simple) alternative would be to only match from the start of a token; from what I understand this is what @barmac stumbled upon. en should match End rather than went.

One assumption I have (not tested) is that re-ordering elements in the search results will confuse me.

@nikku
Copy link
Member

nikku commented Mar 17, 2023

CC @YanaSegal. Maybe you have some general UX insights to share.

@smbea smbea removed their assignment Mar 21, 2023
@smbea smbea added the spring cleaning Could be cleaned up one day label Mar 21, 2023
@smbea
Copy link
Contributor

smbea commented Mar 23, 2023

Me and @YanaSegal discussed this topic yesterday and ended up discussing how the search could work in a more general aspect.

  • Search by "starts with" or "contains strict term". For example:
    • If you search for "en":
      • "end event" will match
      • "start event" would not match
    • If you search for "end": "error end event" will also match
  • Search by group name too
  • Keep groups during search and do not re-order entries. Instead, re-order groups by relevance of search results
    • Prioritization order would be: label > description > group

With this discussion, the capability of collapsing/expanding groups also came up. I created a separate issue for this: bpmn-io/diagram-js#764

@nikku nikku added the fixed upstream Requires integration of upstream change label Nov 4, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Nov 4, 2024
@nikku nikku self-assigned this Nov 5, 2024
@nikku
Copy link
Member

nikku commented Nov 20, 2024

Depends on camunda/camunda-bpmn-js#393 to be released and incorporated.

nikku added a commit that referenced this issue Nov 20, 2024
@nikku nikku added the ready Ready to be worked on label Nov 20, 2024 — with bpmn-io-tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label Nov 20, 2024
@nikku
Copy link
Member

nikku commented Nov 20, 2024

Unfortunately not fully addressed via #4711 (yet):

capture iDtIjs_optimized

(Fails with Event as a search term, expected to prioritize Event-based Gateway over other search results).

@nikku
Copy link
Member

nikku commented Nov 21, 2024

I looked into this again, via bpmn-io/diagram-js#953. First I thought that it would be unexpected that we still group search results (while the results are actually in a chaotic order). However #3439 (comment) backed up that we want to:

  • Still have items grouped
  • Show most relevant group first

➡️ This is what we do today, and will ship, cf. bpmn-io/diagram-js#953.

@nikku
Copy link
Member

nikku commented Nov 21, 2024

CC @lmbateman regarding #3439 (comment) and #3439 (comment).

@nikku nikku added this to the M83 milestone Nov 21, 2024
@nikku nikku added the fixed upstream Requires integration of upstream change label Nov 21, 2024 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Nov 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Nov 21, 2024
nikku added a commit that referenced this issue Nov 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 21, 2024
@barmac barmac closed this as completed in e246745 Nov 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN enhancement New feature or request modeling spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants