Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add market place support to contextual menus #322

Closed
marcellobarile opened this issue Nov 6, 2023 · 4 comments · Fixed by #345
Closed

Add market place support to contextual menus #322

marcellobarile opened this issue Nov 6, 2023 · 4 comments · Fixed by #345
Assignees
Labels
enhancement New feature or request ux

Comments

@marcellobarile
Copy link

marcellobarile commented Nov 6, 2023

Is your feature request related to a problem? Please describe.

With https://github.com/camunda/web-modeler/issues/6066 we have introduced a new icon, to open the marketplace browse dialog, to the following contextual menus:
bpmn-create, bpmn-replace, bpmn-append, and element-template-chooser.
We did it by registering an extension provider for each of them: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L29-L32

We have also added a new call to action when there are no search results, and we did it by listening for mutations on the DOM node: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L74C3-L91C4

The second approach, looks error-prone and hard to maintain (e.g. what if selectors change in the core libraries?); but at that time it was the only viable solution to achieve the requirement.

Describe the solution you'd like

Do we have, or might implement, something better to add the marketplace icon?
Would it be possible to expose something (e.g. a rendering function) to customize or extend the search results?

Additional context

PR with changes: https://github.com/camunda/web-modeler/pull/6154/files#

What does it look like:
image
image
image


Depends on bpmn-io/diagram-js#846

@marcellobarile marcellobarile added enhancement New feature or request ux labels Nov 6, 2023
@nikku nikku added the ready Ready to be worked on label Dec 12, 2023
@nikku
Copy link
Member

nikku commented Dec 12, 2023

Moving to ready to un-park this item.

@nikku
Copy link
Member

nikku commented Jan 23, 2024

@marcellobarile Via bpmn-io/diagram-js#847 you'll be able to create a popup menu provider that contributes a custom empty state. This way you shall be able to implement your use-case.

@nikku nikku added needs review Review pending and removed in progress Currently worked on labels Jan 23, 2024
@marcellobarile
Copy link
Author

great news @nikku ! I'll prepare an issue on our end to embrace the change! :)

@nikku nikku added the fixed upstream Requires integration of upstream change label Jan 30, 2024 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Jan 30, 2024
@nikku
Copy link
Member

nikku commented Jan 30, 2024

Will be released with [email protected] and has to be integrated.

nikku added a commit that referenced this issue Feb 6, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Feb 6, 2024
nikku added a commit that referenced this issue Feb 6, 2024
Closes #322

BREAKING CHANGE: Removes (broken) touch support.
nikku added a commit that referenced this issue Feb 6, 2024
Closes #322

BREAKING CHANGE: Removes (broken) touch support.
@nikku nikku closed this as completed in #345 Feb 6, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants