-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add market place support to contextual menus #322
Labels
Comments
Moving to |
This was referenced Jan 17, 2024
@marcellobarile Via bpmn-io/diagram-js#847 you'll be able to create a popup menu provider that contributes a custom empty state. This way you shall be able to implement your use-case. |
nikku
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Jan 23, 2024
great news @nikku ! I'll prepare an issue on our end to embrace the change! :) |
nikku
added
the
fixed upstream
Requires integration of upstream change
label
Jan 30, 2024
— with
bpmn-io-tasks
Will be released with [email protected] and has to be integrated. |
nikku
added a commit
that referenced
this issue
Feb 6, 2024
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
fixed upstream
Requires integration of upstream change
labels
Feb 6, 2024
nikku
added a commit
that referenced
this issue
Feb 6, 2024
Closes #322 BREAKING CHANGE: Removes (broken) touch support.
nikku
added a commit
that referenced
this issue
Feb 6, 2024
Closes #322 BREAKING CHANGE: Removes (broken) touch support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
With https://github.com/camunda/web-modeler/issues/6066 we have introduced a new icon, to open the marketplace browse dialog, to the following contextual menus:
bpmn-create
,bpmn-replace
,bpmn-append
, andelement-template-chooser
.We did it by registering an extension provider for each of them: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L29-L32
We have also added a new call to action when there are no search results, and we did it by listening for mutations on the DOM node: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L74C3-L91C4
The second approach, looks error-prone and hard to maintain (e.g. what if selectors change in the core libraries?); but at that time it was the only viable solution to achieve the requirement.
Describe the solution you'd like
Do we have, or might implement, something better to add the marketplace icon?
Would it be possible to expose something (e.g. a rendering function) to customize or extend the search results?
Additional context
PR with changes: https://github.com/camunda/web-modeler/pull/6154/files#
What does it look like:
Depends on bpmn-io/diagram-js#846
The text was updated successfully, but these errors were encountered: