Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requirejs to a version >= 2.3.7 #4489

Closed
9 of 10 tasks
tasso94 opened this issue Jul 16, 2024 · 6 comments
Closed
9 of 10 tasks

Bump requirejs to a version >= 2.3.7 #4489

tasso94 opened this issue Jul 16, 2024 · 6 comments
Assignees
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.15 version:7.20.8 version:7.21.4 version:7.22.0-alpha5 version:7.22.0

Comments

@tasso94
Copy link
Member

tasso94 commented Jul 16, 2024

Acceptance Criteria (Required on creation)

Bump requirejs to a version >= 2.3.7.

Hints

Links

Follow up

Preview Give feedback
  1. type:task

Breakdown

Main PR

Preview Give feedback
  1. ci:e2e
    venetrius

7.21 PR

Preview Give feedback

7.20 PR

Preview Give feedback

7.19 PR

Preview Give feedback

Other PR

Preview Give feedback
  1. venetrius

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@tasso94 tasso94 added type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.22.0 potential:7.21.4 labels Jul 16, 2024
psavidis added a commit that referenced this issue Jul 31, 2024
psavidis added a commit that referenced this issue Jul 31, 2024
@psavidis psavidis self-assigned this Jul 31, 2024
psavidis added a commit that referenced this issue Aug 1, 2024
psavidis added a commit that referenced this issue Aug 1, 2024
@psavidis psavidis assigned venetrius and unassigned psavidis Aug 2, 2024
venetrius added a commit that referenced this issue Aug 7, 2024
venetrius added a commit that referenced this issue Aug 7, 2024
venetrius added a commit to camunda/requirejs-angular-define that referenced this issue Aug 16, 2024
@tasso94
Copy link
Member Author

tasso94 commented Aug 16, 2024

Let's try out this example plugin to ensure requirejs and ngDefine works after the update:
example plugin.

venetrius added a commit that referenced this issue Aug 16, 2024
@venetrius
Copy link
Member

venetrius commented Aug 16, 2024

  • updated requierjs in requirejs-angular-define to 2.3.7. requirejs-angular-define has not been updated for a while, I was not able to run the test suites. Created a follow up task to fix that.
  • bumped requirejs-angular-define in camunda-bpm-platform && camunda-bpm-platform-ee to lates commit in - -requirejs-angular-define#master
  • tested that the linked plugin is working

npm list requirejs

[email protected] /Users/gergely.juhasz/code/camunda-bpm-platform-ee/webapps/camunda-webapp/plugins/frontend
├─┬ [email protected] -> ./target/camunda-webapp-frontend-sources
│ └── [email protected] deduped
├─┬ [email protected] (git+ssh://[email protected]/camunda/requirejs-angular-define.git#20f44d0a7b29d70e240defbfa843decce2bc4550)
│ └── [email protected] deduped
└── [email protected]

@tasso94 tasso94 assigned venetrius and unassigned tasso94 Aug 16, 2024
venetrius added a commit that referenced this issue Aug 17, 2024
* chore(webapps): bump requirejs to latest - 2.3.7

related to #4489
@venetrius
Copy link
Member

QA note:

Let's try out this example plugin to ensure requirejs and ngDefine works after the update:
example plugin.

@venetrius venetrius assigned gbetances089 and unassigned venetrius Aug 17, 2024
@gbetances089
Copy link
Member

@venetrius I just tried the cats plugin on the ticket as follow:

Using the Tomcat distro (camunda-bpm-ee-tomcat-7.22.0-20240819.170843-73)
1- added the plugin.js under the server/apache-tomcat10../webapps/camunda/plugin/tasklist/app/
2- added the config.js under the server/apache-tomcat10../webapps/camunda/app/tasklist/scripts/

But the plugin doesn't load bc of this error:

Uncaught Error: Script error for "tasklist.plugin.cats-plugin" https://requirejs.org/docs/errors.html#scripterror at makeError (deps.js?bust=7.20.7:2:2123) at HTMLScriptElement.onScriptError (deps.js?bust=7.20.7:2:17502)

Is this script still valid?

@danielkelemen
Copy link
Member

Trying with camunda-bpm-ee-tomcat-7.22.0-20240823.130805-78.zip.

It works for me:
image

@gbetances089, Looks like your plugin.js is not at the correct place. It should be also under app/tasklist/scripts. At least the default config.js defines it so (scripts/plugin).
Can you try again?

@gbetances089
Copy link
Member

Verified on camunda-bpm-ee-tomcat-7.22.0-20240819.170843-73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.19.15 version:7.20.8 version:7.21.4 version:7.22.0-alpha5 version:7.22.0
Projects
None yet
Development

No branches or pull requests

6 participants