-
Notifications
You must be signed in to change notification settings - Fork 0
/
PULL_REQUEST_TEMPLATE
23 lines (19 loc) · 1.14 KB
/
PULL_REQUEST_TEMPLATE
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
# Submit a pull request
## Please make sure the following is true:
- [ ] I gave the PR a meaningful name
- [ ] I checked that the correct target branch is selected
- [ ] I rebased the branch on the target branch and it can be merged
- [ ] I ran the linter and it did pass
- [ ] I checked for unused code / dead code / debug code
- [ ] I checked that variables/functions have meaningful names
- [ ] I checked that the behaviour is as the documentation/task describes and I tested it
- [ ] I updated the docs / specifications if possible
- [ ] I could explain all that code when someone wakes me up at 3am
- [ ] I checked that the code considers failures and not just the happy path
- [ ] There are no new dependencies OR I listed them and explained them below
- [ ] PR introduces no breaking changes OR I listed them and described them below
- [ ] I added/updated tests for new/modified unit-testable functions/helpers
- [ ] I ran the tests and they did pass
## Other information/comments (e.g. reasons why points are not checked from above)
## Reason for this PR
*Add a short description what this PR does. E.g. "solves issue [link]" or "makes everything better"*