Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Review all settings using units #109

Open
chris-pearce opened this issue Mar 12, 2017 · 1 comment
Open

Review all settings using units #109

chris-pearce opened this issue Mar 12, 2017 · 1 comment
Labels

Comments

@chris-pearce
Copy link
Contributor

Defining units on settings makes them really rigid, e.g.:

$shell-g-border-radius: 3px;

https://github.com/campaignmonitor/shell/blob/master/src/_settings.scss#L208

If we wanted a larger radius we can't do:

$shell-g-border-radius-large: $shell-g-border-radius + 1;

Let's review all settings with units.

@chris-pearce
Copy link
Contributor Author

It seems Sass allows this now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant