-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive GigE implementation #198
Draft
WhiteBlackGoose
wants to merge
69
commits into
cameleon-rs:main
Choose a base branch
from
WhiteBlackGoose:gige
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
It is however enough for the camera I need, and maybe I'll extend it if I get another camera which needs something beyond that.
The purpose of this PR is to share my work, in case someone's use case is exactly the same as mine (simple GigE cameras)
This PR is based on Y-Nak's work (and in fact, by far most of the work belongs to this person, I just finished the streaming part for my use case)
I didn't name my commits properly because if I'm actually to finish this PR so we could merge it, I'd imagine I'd need to squash and rewrite them many times because I expect quite a fair bit of feedback/change requests from the maintainer
GigE Example App
Check
test_all.sh
is passed. Answer: It doesn't, but it's not my faultAdd
fix #{ISSUE_NUMBER}
if the corresponding issue exists.Fill out
## Changelog
section. If the change is for only internal use, please writeNone
to the section.Changelog
gige::enumerate_cameras
requires an IP address of the host to listen to cameras from