Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libusb1-sys to allow newest rusb #190

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Bump libusb1-sys to allow newest rusb #190

merged 1 commit into from
Aug 21, 2024

Conversation

strohel
Copy link
Member

@strohel strohel commented Aug 19, 2024

...which fixes a panic in dev builds / undefined behavior in release builds: a1ien/rusb#195

See #188 (comment) and above.

  • Check test_all.sh is passed.
  • Add fix #{ISSUE_NUMBER} if the corresponding issue exists.
  • Fill out ## Changelog section. If the change is for only internal use, please write None to the section.

Changelog

...which fixes a panic in dev builds / undefined behavior in release builds: a1ien/rusb#195

See #188 (comment) and above.
@strohel strohel requested review from bschwind and Y-Nak August 19, 2024 13:53
Base automatically changed from fix-clippy-1.79 to main August 21, 2024 13:33
Copy link
Member

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Y-Nak Y-Nak merged commit e4c0a86 into main Aug 21, 2024
5 checks passed
@Y-Nak Y-Nak deleted the bump-libusb branch August 21, 2024 13:35
@strohel
Copy link
Member Author

strohel commented Aug 22, 2024

Thanks for merging the PRs, @Y-Nak!

I'm thinking that we could cut a release it, what do you think?

@Y-Nak
Copy link
Member

Y-Nak commented Aug 22, 2024

@strohel yep, it sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants