Improve use of EndDateable for GetAll filtering #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 82.22% 81.97% -0.25%
==========================================
Files 20 22 +2
Lines 1384 1426 +42
==========================================
+ Hits 1138 1169 +31
- Misses 158 164 +6
- Partials 88 93 +5 |
- This avoids having duplicated implementations of in-memory storage - Also fixes the issue with pointers being stored in a map and being externally mutable - Makes things more consistent if switching to Hord storage later on
calvinmclean
force-pushed
the
feature/improve-end-date-kv
branch
from
f9fd814
to
e6e0013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.