-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WARN Codegen didn't run for RNCTabView on RN 0.75.4 and RNBT 0.1.2 #87
Comments
Same here. The problem does not occur on iOS or tvOS. This happens when new arch is enabled. When new arch disabled, I see a different error, this one when updating the "items" property in the module. |
Hey, can you try with version 0.1.4? |
The tab bar renders along with icons! However, it seems like labels only render for initial frame before disappearing. When BTW, typehinting for |
Can you try Changing the Or change it in Android Studio, https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/android-native-styling.html The Material3 style will be the default once I get expo config plugin working inside of the package.
Thanks for checking it out, this needs a separate issue. |
While the styles do apply from Code const HomeTabs = createNativeBottomTabNavigator<BottomNavigatorParamList>();
function HomeTabsNavigator() {
const { t } = useTranslation();
return (
<HomeTabs.Navigator
tabBarInactiveTintColor="#C57B57"
tabBarActiveTintColor="#F7DBA7"
barTintColor="#1E2D2F"
rippleColor="#F7DBA7"
activeIndicatorColor="#041F1E"
>
<HomeTabs.Screen
name="Library"
component={LibraryTopTabNavigator}
options={{
title: t("label.library"),
tabBarLabel: "Library",
tabBarIcon: () => require("../../assets/images/react-logo.png"),
}}
/>
<HomeTabs.Screen
name="General"
component={GeneralScreen}
options={{
title: t("label.general"),
tabBarLabel: "Library",
tabBarIcon: () => require("../../assets/images/react-logo.png"),
}}
/>
<HomeTabs.Screen
name="Updates"
component={UpdatesScreen}
options={{
title: t("label.updates"),
tabBarLabel: "Library",
tabBarIcon: () => require("../../assets/images/react-logo.png"),
}}
/>
<HomeTabs.Screen
name="Browse"
component={BrowseTopTabNavigator}
options={{
title: t("label.browse"),
tabBarIcon: () => require("../../assets/images/react-logo.png"),
}}
/>
<HomeTabs.Screen
name="More"
// On iOS, we put the MoreStack in the Bottom Tabs navigator
component={Platform.OS === "ios" ? MoreStackNavigator : MoreScreen}
options={{
title: t("label.more"),
tabBarIcon: () => require("../../assets/images/react-logo.png"),
}}
/>
</HomeTabs.Navigator>
);
} Are you able to repro?
I'll open a new one. |
@shovel-kun Interesting.. I couldn't repro this. Can you create a minimal example app where this occurs? Would be really helpful 🙏 |
For people that encounter this issue in the future, can we move the rendering issue to a separate one? This will make it easier to search among issues. The issue with "Codegen didn't run.." is fixed, I'll close this one. Can you please open a new issue with a repro @shovel-kun for the issue you are having? |
Found the issue. It was actually related to Not sure if this is something that can be resolved on |
I'm happy that you found the root cause @shovel-kun, I'm not sure if this can be handled on bottom-tabs side, technically native views should adapt automatically.. I've created a feature request in the edge-to-edge repo to add additional styles: zoontek/react-native-edge-to-edge#38 @zoontek do you know if there is anything special I should do to handle edge-to-edge? |
@okwasniewski I will have a look, but I think there's no need for an adaptation of |
@shovel-kun Following this: #97 |
Here's the warning:
The bottom tab fails to render on Android (have not test on iOS).
Adding
module:@react-native/babel-preset
to my babel config (after removingbabel-preset-expo
from presets and rebuilding) has no effect.Don't have a repro atm. Just reporting in case anyone else also has the same problem.
my babel preset can be seen below:
The text was updated successfully, but these errors were encountered: