Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Dependencies to @haul-bundler/babel-preset-react-native #768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Stuart-Wilcox
Copy link

@Stuart-Wilcox Stuart-Wilcox commented Mar 9, 2022

Summary

Add missing dependencies @babel/plugin-transform-computed-properties to @haul-bundler/babel-preset-react-native.

The following dependencies are used in @haul-bundler/babel-preset-react-native

However they are not declared in the dependencies of package.json for @haul-bundler/babel-preset-react-native.

I have encountered errors while trying to use this in a non-hoisted environment, and I believe this was working previously due to hoisting.

Test plan

This should not affect anything, the dependency was likely being resolved previously due to hoisting, and it is simply now being explicitly declared

@Stuart-Wilcox Stuart-Wilcox changed the title Add Missing Dependency @babel/plugin-transform-computed-properties Add Missing Dependencies @babel/plugin-transform-computed-properties Mar 9, 2022
@Stuart-Wilcox Stuart-Wilcox changed the title Add Missing Dependencies @babel/plugin-transform-computed-properties Add Missing Dependencies @haul-bundler/babel-preset-react-native Mar 10, 2022
@Stuart-Wilcox Stuart-Wilcox changed the title Add Missing Dependencies @haul-bundler/babel-preset-react-native Add Missing Dependencies to @haul-bundler/babel-preset-react-native Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant