Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: configuration #6

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Fix: configuration #6

merged 2 commits into from
Aug 26, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Aug 26, 2023

Small fixes to config handling:

  • For tests that call out to the CLI via subprocess.call(), ensure that a real config file present locally is not used
  • Simplify changing config files via CLI:

Before:

$ littlepay config -c /path/to/config.yaml

This PR:

$ littlepay config /path/to/config.yaml

or

$ littlepay -c /path/to/config.yaml

either through a flag on the main command:

  littlepay -c /path/to/config.yaml
  littlepay --config /path/to/config.yaml

or an optional path on the config subcommand:

  littlepay config /path/to/config.yaml
@github-actions
Copy link

Coverage report

The coverage rate went from 96.05% to 96.07% ⬆️
The branch rate is 94%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

littlepay/main.py

100% of new lines are covered (91.89% of the complete file).

@thekaveman thekaveman merged commit 2f0e708 into main Aug 26, 2023
1 check passed
@thekaveman thekaveman deleted the fix/config branch August 26, 2023 20:54
@thekaveman thekaveman added the cli New command line interface feature implementation or refactor label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli New command line interface feature implementation or refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant