-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: define API client wrapping grants flow #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* devcontainer configuration * stub out CLI app with sub-commands * pytest for testing, run in CI
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)littlepay/config.py
littlepay/api/client.py
|
thekaveman
force-pushed
the
feat/config
branch
from
August 24, 2023 00:04
dc79579
to
655f8dd
Compare
thekaveman
force-pushed
the
feat/api/client
branch
from
August 24, 2023 00:04
d9dfeb5
to
6c32aa3
Compare
last used path is stored in a separate file
replaces info command as new default
thekaveman
force-pushed
the
feat/config
branch
2 times, most recently
from
August 24, 2023 07:22
13f6a2f
to
c9d39a0
Compare
participant should have all auth keys for the env
users can delete their config or target a new file
thekaveman
force-pushed
the
feat/config
branch
from
August 24, 2023 08:01
c9d39a0
to
668a641
Compare
optionally reuse an existing token
authlib sends a form-encoded body in POST with no way to override Littlepay requires a JSON-encoded body, implement token refresh by hand
thekaveman
force-pushed
the
feat/api/client
branch
from
August 24, 2023 08:03
6c32aa3
to
7e2ab8f
Compare
thekaveman
force-pushed
the
feat/config
branch
from
August 24, 2023 18:57
668a641
to
beed794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Authlib'sOAuth2Session
forrequests
Tried Authlib at first, but they follow the OAuth2 spec to the letter, meaning POST bodies are sent as
application/x-www-form-urlencoded
while Littlepay's API requiresappliction/json
.(There does not seem to be a way to change the body type in Authlib)